Skip to content

Conversation

JustinCappos
Copy link

This PR which needs community feedback and also needs a more precise linking to the specific standards which apply.

Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general direction. I think we need more clarity (and also feedback from others, of course)

- id: OSPS-SA-04.01
text: |
A project MUST perform a security assessment of the software
supply chain security practices of the project. This should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supply chain security practices of the project. This should
supply chain security practices of the project to

If we don't introduce new instances of "should" in the title or text fields, I won't have to go back and remove them when I get around to doing that. :-)

- id: OSPS-SA-04
title: |
The project MUST assess the security risks inherent in their software supply chain practices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need some wordsmithing to be a little more clear, but I wouldn't block on this if we can't think of anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there projects that are doing this well, doing this poorly today? What does good enough look like?

- Maturity Level 2
- Maturity Level 3
recommendation: |
Performing a security assessment informs both project members as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a place where we'll really want some reference implementations to direct people to.

practices. Ensure this is updated as practices change.
- id: OSPS-SA-04.02
text: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on what distinction you're drawing between 04.01 and 04.02. It seems like some of 04.02 is duplicative, and if so, we can drop that. Is the idea that 04.02 says "do what you did for 04.01, but also include your dependencies in it"?

The text should also be shorter here, ideally 1-2 sentences, and we can expand in the recommendation if needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also mean to look at your tooling. Are you using appropriate VCS controls? Are you generating attestations? Is your software update infrastructure compromise-resilient? Do you have a recovery plan for a compromise in these areas?

- id: OSPS-SA-04
title: |
The project MUST assess the security risks inherent in their software supply chain practices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there projects that are doing this well, doing this poorly today? What does good enough look like?

title: |
The project MUST assess the security risks inherent in their software supply chain practices.
objective: |
Provide project maintainers an understanding of the risks in their software
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "tooling" specific or should that be removed?

Comment on lines +357 to +358
that could occur in the supply chain of the software, including
both the tool.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "including both the tool."?

text: |
When the project has made a release, the project MUST perform a
security assessment of their software supply chain practices and
have analyzed their dependencies. This should also include means
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency management should be effective covered by existing controls.

applicability:
- Maturity Level 3
recommendation: |
Threat modeling of the software supply chain is an essential part
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there existing examples of open source projects doing this well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants